Fix external merge in python index module#437
Open
hendrikmuhs wants to merge 4 commits into
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| std::vector<std::string> args; | ||
| std::string token; | ||
| while (iss >> token) { | ||
| args.push_back(std::move(token)); |
Contributor
There was a problem hiding this comment.
warning: no header providing "std::move" is directly included [misc-include-cleaner]
keyvi/include/keyvi/index/internal/merge_job.h:27:
- #include <vector>
+ #include <utility>
+ #include <vector>|
|
||
| external_process_.reset( | ||
| new boost::process::v2::process(*external_process_ctx, payload_.settings_.GetKeyviMergerBin(), args)); | ||
| external_process_.reset(new boost::process::v2::process(*external_process_ctx, executable, args)); |
Contributor
There was a problem hiding this comment.
warning: initializing non-owner argument of type 'boost::process::basic_process<> *' with a newly created 'gsl::owner<>' [cppcoreguidelines-owning-memory]
external_process_.reset(new boost::process::v2::process(*external_process_ctx, executable, args));
^|
|
||
| external_process_.reset( | ||
| new boost::process::v2::process(*external_process_ctx, payload_.settings_.GetKeyviMergerBin(), args)); | ||
| external_process_.reset(new boost::process::v2::process(*external_process_ctx, executable, args)); |
Contributor
There was a problem hiding this comment.
warning: use std::make_shared instead [modernize-make-shared]
Suggested change
| external_process_.reset(new boost::process::v2::process(*external_process_ctx, executable, args)); | |
| external_process_ = std::make_shared<boost::process::v2::process>(*external_process_ctx, executable, args); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
external merge in the python module was broken after switching process creation