-
Notifications
You must be signed in to change notification settings - Fork 359
[Keypad] Fix Keypad uneven keys column width #3059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ivyolamit
wants to merge
2
commits into
LEMS-3361/refactor-fake-react-native-web
Choose a base branch
from
LEMS-3361/fix-keypad-column-width
base: LEMS-3361/refactor-fake-react-native-web
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Keypad] Fix Keypad uneven keys column width #3059
ivyolamit
wants to merge
2
commits into
LEMS-3361/refactor-fake-react-native-web
from
LEMS-3361/fix-keypad-column-width
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
|
Size Change: 0 B Total Size: 498 kB ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (98f5ded) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3059If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3059If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3059 |
mark-fitzgerald
approved these changes
Nov 21, 2025
jeremywiebe
approved these changes
Nov 21, 2025
5a7da89 to
927b1c7
Compare
4262057 to
fc65629
Compare
927b1c7 to
fdd906c
Compare
fc65629 to
98f5ded
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix Keypad uneven keys column width, see keys from the screenshot below on the 6th column.
Context: Refer to parent PR #2952 when the bug was introduced in Refactoring Keypad from using custom tab components to WB Tabs component.
Issue: LEMS-3361
Test plan: