Skip to content

Conversation

@ivyolamit
Copy link
Contributor

@ivyolamit ivyolamit commented Nov 21, 2025

Summary:

Fix Keypad uneven keys column width, see keys from the screenshot below on the 6th column.
Context: Refer to parent PR #2952 when the bug was introduced in Refactoring Keypad from using custom tab components to WB Tabs component.

Issue: LEMS-3361

Before After
image image

Test plan:

@ivyolamit ivyolamit self-assigned this Nov 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

🗄️ Schema Change: No Changes ✅

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

🛠️ Item Splitting: No Changes ✅

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

Size Change: 0 B

Total Size: 498 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 20.8 kB
packages/keypad-context/dist/es/index.js 1 kB
packages/kmath/dist/es/index.js 5.98 kB
packages/math-input/dist/es/index.js 98.3 kB
packages/math-input/dist/es/strings.js 1.61 kB
packages/perseus-core/dist/es/index.item-splitting.js 13.1 kB
packages/perseus-core/dist/es/index.js 22.6 kB
packages/perseus-editor/dist/es/index.js 98.2 kB
packages/perseus-linter/dist/es/index.js 8.64 kB
packages/perseus-score/dist/es/index.js 9.2 kB
packages/perseus-utils/dist/es/index.js 403 B
packages/perseus/dist/es/index.js 202 kB
packages/perseus/dist/es/strings.js 7.73 kB
packages/pure-markdown/dist/es/index.js 1.39 kB
packages/simple-markdown/dist/es/index.js 6.72 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (98f5ded) and published it to npm. You
can install it using the tag PR3059.

Example:

pnpm add @khanacademy/perseus@PR3059

If you are working in Khan Academy's frontend, you can run the below command.

./dev/tools/bump_perseus_version.ts -t PR3059

If you are working in Khan Academy's webapp, you can run the below command.

./dev/tools/bump_perseus_version.js -t PR3059

@ivyolamit ivyolamit marked this pull request as ready for review November 21, 2025 00:22
@ivyolamit ivyolamit added the project agnostic PRs reviewable by any Perseus team member label Nov 21, 2025
@ivyolamit ivyolamit force-pushed the LEMS-3361/refactor-fake-react-native-web branch from 5a7da89 to 927b1c7 Compare December 5, 2025 21:45
@ivyolamit ivyolamit force-pushed the LEMS-3361/fix-keypad-column-width branch from 4262057 to fc65629 Compare December 5, 2025 21:46
@ivyolamit ivyolamit force-pushed the LEMS-3361/refactor-fake-react-native-web branch from 927b1c7 to fdd906c Compare December 5, 2025 23:06
@ivyolamit ivyolamit force-pushed the LEMS-3361/fix-keypad-column-width branch from fc65629 to 98f5ded Compare December 5, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

olc-5.0.d5056 project agnostic PRs reviewable by any Perseus team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants