Skip to content

Conversation

@anakaren-rojas
Copy link
Contributor

@anakaren-rojas anakaren-rojas commented Nov 22, 2025

Summary:

  • Add review mode to content preview to allow correct styling of choice button

Issue: LEMS-3459

Test plan:

ZND

  1. Navigate to any editor with a radio
  2. In right hand preview panel, correct answer should be styled with: green border, while the choice should have a white check mark, green fill, and be pill shaped
  3. Styling should match that of the left content panel

Screenshots

Production

image

Local Dev && ZND

image

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2025

🗄️ Schema Change: No Changes ✅

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2025

🛠️ Item Splitting: No Changes ✅

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2025

Size Change: +13 B (0%)

Total Size: 498 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 97.9 kB +7 B (+0.01%)
packages/perseus/dist/es/index.js 202 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 20.8 kB
packages/keypad-context/dist/es/index.js 1 kB
packages/kmath/dist/es/index.js 5.98 kB
packages/math-input/dist/es/index.js 99.2 kB
packages/math-input/dist/es/strings.js 1.61 kB
packages/perseus-core/dist/es/index.item-splitting.js 13.1 kB
packages/perseus-core/dist/es/index.js 22.5 kB
packages/perseus-linter/dist/es/index.js 8.64 kB
packages/perseus-score/dist/es/index.js 9.2 kB
packages/perseus-utils/dist/es/index.js 403 B
packages/perseus/dist/es/strings.js 7.73 kB
packages/pure-markdown/dist/es/index.js 1.39 kB
packages/simple-markdown/dist/es/index.js 6.71 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2025

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (a9926a1) and published it to npm. You
can install it using the tag PR3065.

Example:

pnpm add @khanacademy/perseus@PR3065

If you are working in Khan Academy's frontend, you can run the below command.

./dev/tools/bump_perseus_version.ts -t PR3065

If you are working in Khan Academy's webapp, you can run the below command.

./dev/tools/bump_perseus_version.js -t PR3065

@anakaren-rojas anakaren-rojas marked this pull request as ready for review November 24, 2025 21:37
Copy link
Contributor

@mark-fitzgerald mark-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@SonicScrewdriver SonicScrewdriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! We can discuss reviewMode / showSolutions later as we probably need a holistic decision there. Thanks for improving the editors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants