-
Notifications
You must be signed in to change notification settings - Fork 359
fix(LEMS-3459): add review mode to content preview #3065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🗄️ Schema Change: No Changes ✅ |
🛠️ Item Splitting: No Changes ✅ |
|
Size Change: +13 B (0%) Total Size: 498 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (a9926a1) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3065If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3065If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3065 |
…t preview to show correct styling for radio
…preview-pane-radio
mark-fitzgerald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
SonicScrewdriver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! We can discuss reviewMode / showSolutions later as we probably need a holistic decision there. Thanks for improving the editors!
Summary:
Issue: LEMS-3459
Test plan:
ZND
Screenshots
Production
Local Dev && ZND