Skip to content

Revert "Sort PhysicalDevices to match ICD's ordering"#1861

Merged
charles-lunarg merged 2 commits intomainfrom
revert-1744-physical_devices_sorted
Feb 11, 2026
Merged

Revert "Sort PhysicalDevices to match ICD's ordering"#1861
charles-lunarg merged 2 commits intomainfrom
revert-1744-physical_devices_sorted

Conversation

@charles-lunarg
Copy link
Collaborator

Reverts #1744

The change breaks angle tests which fail to find the correct physical device. An example failure error is:

[ RUN      ] TraceTest.supertuxkart
WARN: vulkan_icd.cpp:388 (ChoosePhysicalDevice): Preferred device ICD not found. Using default physicalDevice instead.
GL_RENDERER: ANGLE (Mesa, Vulkan 1.3.255 (llvmpipe (LLVM 15.0.7 256 bits) (0x00000000)), llvmpipe-0.0.1)
GL_VERSION: OpenGL ES 3.1 (ANGLE 2.1.27044 git hash: 2c07b13173f8)
running test name: "TracePerf", backend: "_vulkan", story: "supertuxkart"
Test Trials: 1
../../src/tests/perf_tests/ANGLEPerfTest.h:131: Failure
Failed
Failing test because of unexpected error:
vk_renderer.cpp:1033 (DebugUtilsMessenger): [ SYNC-HAZARD-WRITE-AFTER-WRITE ] vkCmdWaitEvents(): WRITE_AFTER_WRITE hazard detected. vkCmdWaitEvents performs image layout transition on the VkImage 0xe490000000e49, which was previously written by vkCmdEndRenderPass. 

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 3413 running.

1 similar comment
@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 3413 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Loader build # 3413 passed.

@charles-lunarg charles-lunarg merged commit a3d9775 into main Feb 11, 2026
86 checks passed
@charles-lunarg charles-lunarg deleted the revert-1744-physical_devices_sorted branch February 11, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants