Skip to content

Fix line and linesegments clone method. Similar to #113 #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vivagelive wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix line and linesegments clone method. Similar to #113 #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76ac4ce
line_segments.dart, line.dart -> fix clone incorrect, geometry and ma…
vivagelive Mar 27, 2026
76b7afc
group.dart-> fix clone incorrect return type (now return Group instea…
vivagelive Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/three_js_core/lib/objects/group.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,18 @@ class Group extends Object3D {
Group.fromJson(Map<String, dynamic> json, Map<String, dynamic> rootJson):super.fromJson(json, rootJson) {
type = 'Group';
}

@override
Group clone ([bool? recursive = true]) {
return Group()..copy(this, recursive);
}

@override
Group copy(Object3D source, [bool? recursive]) {
super.copy(source, recursive);
if(source is Group) {
this.userData = Map<String, dynamic>.from(source.userData);
}
return this;
}
}
4 changes: 2 additions & 2 deletions packages/three_js_core/lib/objects/line.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ class Line extends Object3D {
Line copy(Object3D source, [bool? recursive]) {
super.copy(source);

material = source.material;
geometry = source.geometry;
material = source.material?.clone();
geometry = source.geometry?.clone();

return this;
}
Expand Down
5 changes: 5 additions & 0 deletions packages/three_js_core/lib/objects/line_segments.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,9 @@ class LineSegments extends Line {

return this;
}

@override
LineSegments clone([bool? recursive = true]) {
return LineSegments(this.geometry)..copy(this, recursive);
}
}
Loading