Fix mLoopCount global setting. #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module repeat count is supposed to be configured via mLoopCount in the Modplug global settings. Setting this to a negative value is supposed to enable looping forever (what game engines are most likely to expect), but for some reason, this feature was *deliberately broken* despite the default being 0. There's no reason for this to be commented out. Fixes Konstanty#51. See also: icculus/SDL_sound#123 https://github.com/AliceLR/megazeux/blob/f83d897dc7df808ed4ad3eb31b5abb6a7b479d08/contrib/patches/libmodplug/01-libmodplug-0.8.9.0-fix-looping.diff
sezero
pushed a commit
to sezero/libmodplug
that referenced
this pull request
Jan 6, 2026
The module repeat count is supposed to be configured via mLoopCount in the Modplug global settings. Setting this to a negative value is supposed to enable looping forever (what game engines are most likely to expect), but for some reason, this feature was *deliberately broken* despite the default being 0. There's no reason for this to be commented out. Fixes Konstanty#51 See also: icculus/SDL_sound#123 https://github.com/AliceLR/megazeux/blob/f83d897dc7df808ed4ad3eb31b5abb6a7b479d08/contrib/patches/libmodplug/01-libmodplug-0.8.9.0-fix-looping.diff Mainstream pull request: Konstanty#102
sezero
pushed a commit
to icculus/SDL_sound
that referenced
this pull request
Jan 6, 2026
The module repeat count is supposed to be configured via mLoopCount in the Modplug global settings. Setting this to a negative value is supposed to enable looping forever (what game engines are most likely to expect), but for some reason, this feature was *deliberately broken* despite the default being 0. There's no reason for this to be commented out. Fixes Konstanty/libmodplug#51 See also: #123 https://github.com/AliceLR/megazeux/blob/f83d897dc7df808ed4ad3eb31b5abb6a7b479d08/contrib/patches/libmodplug/01-libmodplug-0.8.9.0-fix-looping.diff Mainstream pull request: Konstanty/libmodplug#102 Fixes: #123. (cherry picked from commit 427281b)
sezero
pushed a commit
to icculus/SDL_sound
that referenced
this pull request
Jan 6, 2026
The module repeat count is supposed to be configured via mLoopCount in the Modplug global settings. Setting this to a negative value is supposed to enable looping forever (what game engines are most likely to expect), but for some reason, this feature was *deliberately broken* despite the default being 0. There's no reason for this to be commented out. Fixes Konstanty/libmodplug#51 See also: #123 https://github.com/AliceLR/megazeux/blob/f83d897dc7df808ed4ad3eb31b5abb6a7b479d08/contrib/patches/libmodplug/01-libmodplug-0.8.9.0-fix-looping.diff Mainstream pull request: Konstanty/libmodplug#102 Fixes: #123.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module repeat count is supposed to be configured via
mLoopCountin the Modplug global settings. Setting this to a negative value is supposed to enable looping forever (what game engines are most likely to expect), but for some reason, this feature was deliberately broken despite the default being 0. There's no reason for this to be commented out.Fixes #51.
See also:
icculus/SDL_sound#123
https://github.com/AliceLR/megazeux/blob/f83d897dc7df808ed4ad3eb31b5abb6a7b479d08/contrib/patches/libmodplug/01-libmodplug-0.8.9.0-fix-looping.diff