Document thread-safety of Arrays.parallelSort in sortByColumns #1646
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review question about thread-safety of
Arrays.parallelSortusage in the single-column sort optimization path.Changes
parallelSortis thread-safe:column[index]values[index]delegation)The parallelSort implementation is correct as-is. The locally-created permutation array and read-only column access satisfy thread-safety requirements.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.