Skip to content

Add reg leases data#2746

Merged
annajgibson merged 6 commits into
mainfrom
add-reg-leases-data
May 15, 2026
Merged

Add reg leases data#2746
annajgibson merged 6 commits into
mainfrom
add-reg-leases-data

Conversation

@annajgibson
Copy link
Copy Markdown
Contributor

No description provided.

@annajgibson annajgibson requested review from a team as code owners May 15, 2026 13:25
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@Tian-2017 Tian-2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we need to add a cron time line based on the latest module. I think the playbook hasn’t been updated. I see most modules have
ingestion_schedule = "cron(0 21 * * ? *)",
you can change to cron(0 2 ? * MON-FRI *) 02:00 UTC, Monday to Friday

Copy link
Copy Markdown
Contributor

@Tian-2017 Tian-2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I’ve looked into this a bit further. This workflow is complex and includes Lambda and Glue jobs.

If no cron time is provided, it will use the default cron expression: cron(0 6 * * ? *), so that should be fine.

Lambda will still check the file-level metadata regularly using the default cron expression.

However, the downstream Glue job will not run the real ingestion if there are no changes to the CSV.

So it’s safe to merge.

@annajgibson annajgibson merged commit bbbe38b into main May 15, 2026
20 checks passed
@annajgibson annajgibson deleted the add-reg-leases-data branch May 15, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants