munet: Configurable environment variables within Linux Namespace nodes#51
Draft
liambrady wants to merge 2 commits intoLabNConsulting:mainfrom
Draft
munet: Configurable environment variables within Linux Namespace nodes#51liambrady wants to merge 2 commits intoLabNConsulting:mainfrom
liambrady wants to merge 2 commits intoLabNConsulting:mainfrom
Conversation
liambrady
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 58.83% 58.66% -0.18%
==========================================
Files 19 19
Lines 5728 5755 +27
==========================================
+ Hits 3370 3376 +6
- Misses 2358 2379 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Previously, configured env variables would not appear
within Linux namespace nodes. This commit adds support
for such a capability through the `env` config. e.g:
```
topology:
nodes:
- name: r1
env:
- name: foo
value: bar
```
sets the appropriate env variable in both all run
commands and in opened windows.
Fixes LabNConsulting#22
Signed-off-by: Liam Brady <lbrady@labn.net>
Adds a few mutests that check to confirm that env variables are being properly set within Linux Namespace nodes. Signed-off-by: Liam Brady <lbrady@labn.net>
liambrady
force-pushed
the
liambrady/env_namespace
branch
from
8cb1d4b to
3ba9bc3
Compare
choppsv1
force-pushed
the
main
branch
3 times, most recently
from
542f956 to
d3bfa70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, configured env variables would not appear within Linux namespace nodes. This commit adds support for such a capability through the
envconfig. e.g:sets the appropriate env variable in both all run commands and in opened windows.
Closes #22