README: Change YANG connections key to name#94
Closed
liambrady wants to merge 1 commit intoLabNConsulting:mainfrom
Closed
README: Change YANG connections key to name#94liambrady wants to merge 1 commit intoLabNConsulting:mainfrom
connections key to name#94liambrady wants to merge 1 commit intoLabNConsulting:mainfrom
Conversation
Connections were previously keyed based off of `to` (i.e. the remote node/network name), which is not unique in the case of parallel p2p links (managed via `remote-name`) or dummy interfaces. The key is shifted to `name`, which is guarenteed to be unique, even when implicitely set by munet. Signed-off-by: Liam Brady <lbrady@labn.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
=======================================
Coverage 60.62% 60.62%
=======================================
Files 19 19
Lines 5973 5973
=======================================
Hits 3621 3621
Misses 2352 2352 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
choppsv1
reviewed
Jan 13, 2026
Collaborator
choppsv1
left a comment
choppsv1
left a comment
There was a problem hiding this comment.
We don't actually run the config through a YANG parser right now, if we did you'd see this broke almost every config in existence :)
Keys are mandatory. And every connection has a to, this change would require every connection also have a name now.
Contributor
Author
|
Pushing this issue down the road (tracked via issue #96) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections were previously keyed based off of
to(i.e. the remote node/network name), which is not unique in the case of parallel p2p links (managed viaremote-name) or dummy interfaces.The key is shifted to
name, which is guarenteed to be unique, even when implicitely set by munet.