Upgrade packages to minimize the size of dependency graph#1
Open
sucrose0413 wants to merge 1 commit intoLambda3:mainfrom
Open
Upgrade packages to minimize the size of dependency graph#1sucrose0413 wants to merge 1 commit intoLambda3:mainfrom
sucrose0413 wants to merge 1 commit intoLambda3:mainfrom
Conversation
willsbctm
force-pushed
the
main
branch
2 times, most recently
from
4e13fe6 to
21c2604
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi@willsbctm, I found an issue in the DotNet.Core.Runtime.Faker.Integration.Tests.csproj:
Packages Bogus v33.0.1, Microsoft.AspNetCore.Mvc.Testing v3.1.5, nunit v3.13.1, NUnit3TestAdapter v3.17.0 and Microsoft.NET.Test.Sdk v16.8.3 transitively introduce 103 dependencies into DotNet.Core.Runtime.Faker’s dependency graph (see dependency graph before upgrades), while Bogus v33.0.2, Microsoft.AspNetCore.Mvc.Testing v3.1.7, nunit v3.13.2, NUnit3TestAdapter v4.0.0 and Microsoft.NET.Test.Sdk v16.9.1 can only introduce 61 dependencies (see dependency graph after upgrades).
These upgrades can help project minimize the size of dependency graph.
Hope the PR can help you.
Best regards,
sucrose