Add first-run backup security mode selection#12
Add first-run backup security mode selection#12thatdaveguy1 wants to merge 1 commit intoLampese:mainfrom
Conversation
|
Sorry, I don't quite understand what this PR is about. Do we have any security issues? |
Currently, when exporting backup files, the account information is encrypted using a key that is hardcoded in the source code. The contributor's intention is to allow users to set their own custom keys to enhance the security of these backup files. When I originally implemented this feature, I thought managing custom keys might be a bit cumbersome for users, as they would need to ensure they use the exact same key when importing/exporting across different machines. |
Is this encryption necessary? I mean, what impact would it have on a user exporting the plaintext? |
Why
Full backup encryption currently depends on a single built-in fallback secret. That preserves compatibility, but it does not give new users a meaningful security choice.
This PR adds an explicit first-run decision so new users can pick a stronger backup protection model while preserving the existing behavior as a compatibility option.
What changed
src/App.tsxLess Securesettings.rs,account.rs, andtypes.rsReviewer notes
Verification
cargo checkinsrc-tauripasses on this branch