feat(examples): add Sui and Starknet support to oft-main #1919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR SummaryIntroduces a new
Written by Cursor Bugbot for commit 53b9ff5. Configure here. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
St0rmBr3w
force-pushed
the
feat/devtools-sui-examples
branch
from
53b9ff5 to
50c7be8
Compare
7 tasks
Contributor
- Add Sui Move contracts for OFT token and OFT implementation - Add Sui send task with proper RPC connection factory usage - Update layerzero.config.ts with Sui pathway configuration - Add deploy.json.example showing expected deployment format - Update .gitignore to exclude deployment artifacts Configuration notes: - Enforced options order: [TO_SUI_OPTIONS, TO_EVM_OPTIONS] - SUI_ENFORCED_OPTIONS uses 5000 gas (sufficient for Sui) - EVM_ENFORCED_OPTIONS uses 80000 gas (sufficient for EVM)
- Refactor layerzero.config.ts with toggle flags for each VM - Add automatic full mesh pathway generation - Optional deployment file loading (won't crash if missing) - Rewrite README with concise multi-VM instructions - Add endpoint ID reference table - Add troubleshooting section
Key fixes: - Fix fromHex to handle odd-length hex strings by padding with leading '0' (Buffer.from silently truncates odd-length strings) - Fix ByteArray encoding in setEnforcedOptions to use raw calldata instead of string-based encoding (starknet.js UTF-8 re-encodes bytes >= 128) - Update sendStarknet to use createRpcUrlFactory() for RPC URL resolution - Update starknet.js v8 Account constructor format These fixes resolve the "out of bound" error when sending from Starknet OFT caused by corrupted enforced options (byte 0x80 becoming UTF-8 0xc2 0x80).
St0rmBr3w
force-pushed
the
feat/devtools-sui-examples
branch
from
981e74f to
716a53d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dependencies
Once #1918 is merged and packages are published, this PR can be rebased onto
main.Files Added/Modified
examples/oft-main/- Full example with:sui/oft/,sui/token/)tasks/starknet/)tasks/sui/)Test plan
🤖 Generated with Claude Code