Skip to content

fix: update reservoir names to a friendlier format #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josemi1189 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −5
Open

fix: update reservoir names to a friendlier format #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions front/src/pods/embalse-cuenca/embalse-cuenca.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
"use client";
import { Card } from "@/common/components/card.component";
import { Lookup } from "@/common/models";
import { generateSlug } from "db-model";
import Link from "next/link";
import { formatEmbalseDisplayName } from "@/pods/embalse/embalse-name.helper";

export interface Props {
nombreCuenca: string;
Expand All @@ -26,7 +26,7 @@ export const EmbalseCuencaComponent: React.FC<Props> = (props) => {
href={`/embalse/${generateSlug(name)}`}
className="link-accessible"
>
{name}
{formatEmbalseDisplayName(name)}
</Link>
))}
</div>
Expand Down
3 changes: 2 additions & 1 deletion front/src/pods/embalse-provincia/embalse-provincia.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { Card } from "@/common/components/card.component";
import { Lookup } from "@/common/models";
import Link from "next/link";
import React from "react";
import { formatEmbalseDisplayName } from "@/pods/embalse/embalse-name.helper";

interface Props {
nombreProvincia: string;
Expand All @@ -21,7 +22,7 @@ export const EmbalseProvincia: React.FC<Props> = (props) => {
<div className="grid grid-cols-1 gap-4 p-6 sm:grid-cols-2 md:grid-cols-3">
{embalses.map(({ id, name }) => (
<Link key={id} href={`/embalse/${id}`} className="link-accessible">
{name}
{formatEmbalseDisplayName(name)}
</Link>
))}
</div>
Expand Down
6 changes: 4 additions & 2 deletions front/src/pods/embalse/components/reservoir-card-info.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ReservoirInfo } from "../embalse.vm";
import React from "react";
import Image from "next/image";
import { formatEmbalseDisplayName } from "@/pods/embalse/embalse-name.helper";

interface Props {
reservoirInfo: ReservoirInfo;
Expand All @@ -14,7 +14,9 @@ export const ReservoirCardInfo: React.FC<Props> = (props) => {
className="flex w-full flex-col items-start gap-4"
aria-labelledby="discover-title"
>
<h2 id="discover-title">Descubre el embalse {reservoirInfo?.name}</h2>
<h2 id="discover-title">
Descubre el embalse {formatEmbalseDisplayName(reservoirInfo?.name)}
</h2>
<p>{reservoirInfo?.description}</p>
{reservoirInfo?.mainPicture?.url && (
<>
Expand Down
Loading