fix(build): remove floating minor version tag from Docker metadata#198
Merged
fix(build): remove floating minor version tag from Docker metadata#198
Conversation
The {{major}}.{{minor}} semver pattern (e.g. 1.4) conflicts with
DockerHub tag immutability on patch releases. When v1.4.0 is
published the 1.4 tag is created and locked, so subsequent patch
releases like v1.4.1 fail trying to overwrite it.
Remove the floating minor tag, keeping only the exact version tag
(e.g. 1.4.1) and the major tag (e.g. 1).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughRemoved a semantic version tag rule from Docker metadata action configuration in the build workflow. The Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
lerian-studio
added
size/XS
🔍 Lint Analysis
|
🛡️ CodeQL Analysis ResultsLanguages analyzed: ✅ No security issues found. 🔍 View full scan logs | 🛡️ Security tab |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions Shared Workflows
Description
Removes the
type=semver,pattern={{major}}.{{minor}}tag from the Docker metadata step in the build workflow.This floating minor tag (e.g.
1.4) conflicts with DockerHub tag immutability settings. Whenv1.4.0is published, the1.4tag is created and locked. Subsequent patch releases likev1.4.1then fail because they try to overwrite the immutable1.4tag.After this change, the build workflow generates only:
1.4.1) — via{{version}}1) — via{{major}}, only on release tagsType of Change
feat: New workflow or new input/output/step in an existing workflowfix: Bug fix in a workflow (incorrect behavior, broken step, wrong condition)perf: Performance improvement (e.g. caching, parallelism, reduced steps)refactor: Internal restructuring with no behavior changedocs: Documentation only (README, docs/, inline comments)ci: Changes to self-CI (workflows under.github/workflows/that run on this repo)chore: Dependency bumps, config updates, maintenancetest: Adding or updating testsBREAKING CHANGE: Callers must update their configuration after this PRBreaking Changes
None.
Testing
@developor the beta tagCaller repo / workflow run: https://github.com/LerianStudio/product-console/actions/runs/23855041026/job/69545602065
Related Issues
Summary by CodeRabbit