refactor(config): extract ConfigKeysMeta into its own file#1310
Merged
JohnVillalovos merged 1 commit intodevelopfrom Apr 5, 2026
Merged
refactor(config): extract ConfigKeysMeta into its own file#1310JohnVillalovos merged 1 commit intodevelopfrom
JohnVillalovos merged 1 commit intodevelopfrom
Conversation
Move ConfigKeysMeta class from ConfigKeys.php to a dedicated ConfigKeysMeta.php file. Having multiple classes in one file violates PSR-12 and PHP one-class-per-file conventions. Also update one test to use `declare(strict_types=1);`
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the configuration key metadata by moving ConfigKeysMeta out of ConfigKeys.php into its own file, and updates the config namespace loader accordingly. It also aligns one infrastructure test with strict typing.
Changes:
- Extract
ConfigKeysMetaintolib/Config/ConfigKeysMeta.php. - Update
lib/Config/namespace.phpto include the new metadata file. - Add
declare(strict_types=1);totests/Infrastructure/Config/DeprecatedConfigKeysTest.php.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Infrastructure/Config/DeprecatedConfigKeysTest.php | Adds declare(strict_types=1); for consistent strict typing in this test. |
| lib/Config/namespace.php | Ensures ConfigKeysMeta is loaded after extraction by requiring the new file. |
| lib/Config/ConfigKeysMeta.php | New dedicated file containing section titles and top-level grouping metadata constants. |
| lib/Config/ConfigKeys.php | Removes the embedded ConfigKeysMeta class definition from this file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move ConfigKeysMeta class from ConfigKeys.php to a dedicated ConfigKeysMeta.php file. Having multiple classes in one file violates PSR-12 and PHP one-class-per-file conventions.
Also update one test to use
declare(strict_types=1);