[stable32] Continue PR #7342: mobile signature placement flow by backportbot-libresign[bot] · Pull Request #7415 · LibreSign/libresign

backportbot-libresign · 2026-04-05T23:20:46Z

Backport of #7408

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

Review and resolve any conflicts
Remove all the empty commits
Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Signed-off-by: Phillip <phillipxh@gmail.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

- allow self worker-src on authenticated and public sign pages - normalize mailpit sign links to app-relative paths - add regression coverage for sign link extraction and sign-page CSP - configure native signing without TSA in the affected public-sign E2E flows - stabilize unauthenticated sign flows by clearing browser cookies before opening public links Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Updates to v1.2.0 which includes: - first-class pdf-elements:adding-ended event for interactive placement - event payload types (placed/cancelled) exported from package API - full test coverage for both event flows This aligns LibreSign to use the new stable event contract from pdf-elements, complementing the mobile signature placement flow refactorings in this PR. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

The PdfEditor component was still using setTimeout-based polling to detect when pdf-elements placement completed. With pdf-elements v1.2.0, this event is now exposed directly via 'pdf-elements:adding-ended' event with a complete event contract including the placement reason ('placed' or 'cancelled'). Changes: - Remove pendingAddedObjectCount and pendingAddCheckTimer state - Remove polling functions: clearPendingAddCheck, finishPendingAddCheck, checkSignerAdded, scheduleSignerAddedCheck - Remove document event listener registration (mouseup, touchend, keyup) - Add handleAddingEnded(event: Event) to relay pdf-elements:adding-ended directly to pdf-editor:adding-ended with the reason payload - Update emit type definition to include payload with reason field This completes the v1.2.0 migration from polling-based to event-driven completion detection. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Replace obsolete polling-based tests with new tests for the event relay pattern: - Remove: 'schedules a deferred completion check after a placement interaction' - Remove: 'emits adding-ended when object count increases after adding mode starts' - Remove: 'emits adding-ended when adding mode finishes without object delta' - Remove: 'keeps waiting while adding mode is active and count has not changed' - Remove: 'ignores completion checks when no add session is pending' - Remove: 'RULE: document listener lifecycle' test suite Add: 'RULE: pdf-elements event relay' test suite with: - 'relays pdf-elements:adding-ended event to pdf-editor:adding-ended' - 'relays cancelled event with reason' Update type definition PdfEditorVm: - Remove: checkSignerAdded, scheduleSignerAddedCheck - Add: handleAddingEnded(event: Event) All 60 PdfEditor tests now pass with event-driven model. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Phillipxh and others added 30 commits April 5, 2026 23:20

fix(mobile): fix signature placement and coordinate serialization

254fc4c

Signed-off-by: Phillip <phillipxh@gmail.com>

fix(mobile): harden touch placement and pdf-elements runtime behavior

8a4987c

Signed-off-by: Phillip <phillipxh@gmail.com>

test(mobile): increase coverage for signature placement flows

5bcd6c5

Signed-off-by: Phillip <phillipxh@gmail.com>

fix(mobile): restore sign flow fallback for self-signer requests

d90344e

Signed-off-by: Phillip <phillipxh@gmail.com>

test: fix PdfEditor spec runtime mock typing

ec91029

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore(deps): bump pdf-elements to 1.1.4

7073ea0

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore(deps): refresh lockfile for pdf-elements

7cb62f0

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-editor): remove touchend workaround internals

0d3128b

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-editor): decouple model from pdf-elements type export

a388095

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(pdf-worker): import worker setup from exported asyncReader path

2080b48

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(pdf-editor): drop workaround-specific touchend specs

f19ca97

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(vite): remove pdf-elements runtime patch plugin

3e574f5

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore(deps): bump pdf-elements to 1.1.5

9c066cb

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore(deps): refresh lockfile for pdf-elements 1.1.5

4badda2

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-editor): use pdf-elements exported object type

28f5668

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-worker): restore root setWorkerPath import

da9307d

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(sign-route): avoid stale sign_request_uuid fallback

2fd5633

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(sign-route): cover stale state UUID regression

b483e3c

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(pdf-editor): use theme tokens for action buttons

714c675

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(playwright): normalize sign links to relative app paths

5c27bb9

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(playwright): simplify sign-link extraction to relative path

c15c776

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: alias pdf-elements to source in vite

da624f6

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: align pdf-elements alias in vitest

e24cdc1

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: set pdf worker path synchronously

f9610e4

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: initialize pdf worker before editor mount

46e4bf7

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: resolve nested visible element pdf urls

8f7b809

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: load request signature modal pdf blobs

a015570

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: sync right sidebar open state

591905c

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: mark sign store mounted on selection

4bbd507

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

vitormattos added 17 commits April 5, 2026 23:20

chore: refresh frontend lockfile

0ef1ee2

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor: simplify pdf editor add completion flow

3f231d4

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: handle pdf editor add completion event

7a9ab90

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover pdf editor add completion flow

8f1738e

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: update visible elements add completion event

1c66a55

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor: remove redundant PdfEditor lifecycle hooks

ff46d1a

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: stabilize pdf editor action button colors in dark themes

85430fe

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: strengthen toolbar color override selectors

da85c6d

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: target pdf-elements scoped toolbar selector

ec79e64

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: correct toolbar override selector nesting

942719e

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

style: align pdf action toolbar with Nextcloud button aesthetics

8e84c32

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat: consume pdf-elements action styling hooks

70fd0b7

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore: bump pdf-elements dependency to 1.2.1

8deffb7

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore: refresh lockfile for pdf-elements 1.2.1

af16d73

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

backportbot-libresign bot requested a review from vitormattos April 5, 2026 23:20

github-project-automation bot added this to Roadmap Apr 5, 2026

backportbot-libresign bot added the 3. to review label Apr 5, 2026

github-project-automation bot moved this to 0. Needs triage in Roadmap Apr 5, 2026

backportbot-libresign bot added this to the Next Patch (32) milestone Apr 5, 2026

backportbot-libresign bot assigned vitormattos Apr 5, 2026

fix: hide sign action while positioning signer

a1ab4af

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

vitormattos force-pushed the backport/7408/stable32 branch from dfa5839 to a1ab4af Compare April 5, 2026 23:34

vitormattos marked this pull request as ready for review April 5, 2026 23:34

fix: update package lock

64b36a3

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

vitormattos merged commit 02536da into stable32 Apr 5, 2026
68 checks passed

github-project-automation bot moved this from 0. Needs triage to 4. to release in Roadmap Apr 5, 2026

vitormattos deleted the backport/7408/stable32 branch April 5, 2026 23:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[stable32] Continue PR #7342: mobile signature placement flow#7415

[stable32] Continue PR #7342: mobile signature placement flow#7415
vitormattos merged 69 commits intostable32from
backport/7408/stable32

backportbot-libresign bot commented Apr 5, 2026 •

edited by vitormattos

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

backportbot-libresign bot commented Apr 5, 2026 • edited by vitormattos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Todo

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

backportbot-libresign bot commented Apr 5, 2026 •

edited by vitormattos

Loading