[stable33] Continue PR #7342: mobile signature placement flow by backportbot-libresign[bot] · Pull Request #7416 · LibreSign/libresign

backportbot-libresign · 2026-04-05T23:21:01Z

Backport of #7408

Warning, This backport had conflicts that were resolved with the ours merge strategy and is likely incomplete ⚠️

Todo

Review and resolve any conflicts
Remove all the empty commits
Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Signed-off-by: Phillip <phillipxh@gmail.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

- allow self worker-src on authenticated and public sign pages - normalize mailpit sign links to app-relative paths - add regression coverage for sign link extraction and sign-page CSP - configure native signing without TSA in the affected public-sign E2E flows - stabilize unauthenticated sign flows by clearing browser cookies before opening public links Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Updates to v1.2.0 which includes: - first-class pdf-elements:adding-ended event for interactive placement - event payload types (placed/cancelled) exported from package API - full test coverage for both event flows This aligns LibreSign to use the new stable event contract from pdf-elements, complementing the mobile signature placement flow refactorings in this PR. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

The PdfEditor component was still using setTimeout-based polling to detect when pdf-elements placement completed. With pdf-elements v1.2.0, this event is now exposed directly via 'pdf-elements:adding-ended' event with a complete event contract including the placement reason ('placed' or 'cancelled'). Changes: - Remove pendingAddedObjectCount and pendingAddCheckTimer state - Remove polling functions: clearPendingAddCheck, finishPendingAddCheck, checkSignerAdded, scheduleSignerAddedCheck - Remove document event listener registration (mouseup, touchend, keyup) - Add handleAddingEnded(event: Event) to relay pdf-elements:adding-ended directly to pdf-editor:adding-ended with the reason payload - Update emit type definition to include payload with reason field This completes the v1.2.0 migration from polling-based to event-driven completion detection. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Replace obsolete polling-based tests with new tests for the event relay pattern: - Remove: 'schedules a deferred completion check after a placement interaction' - Remove: 'emits adding-ended when object count increases after adding mode starts' - Remove: 'emits adding-ended when adding mode finishes without object delta' - Remove: 'keeps waiting while adding mode is active and count has not changed' - Remove: 'ignores completion checks when no add session is pending' - Remove: 'RULE: document listener lifecycle' test suite Add: 'RULE: pdf-elements event relay' test suite with: - 'relays pdf-elements:adding-ended event to pdf-editor:adding-ended' - 'relays cancelled event with reason' Update type definition PdfEditorVm: - Remove: checkSignerAdded, scheduleSignerAddedCheck - Add: handleAddingEnded(event: Event) All 60 PdfEditor tests now pass with event-driven model. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Phillipxh and others added 30 commits April 5, 2026 23:20

fix(mobile): fix signature placement and coordinate serialization

d2c9986

Signed-off-by: Phillip <phillipxh@gmail.com>

fix(mobile): harden touch placement and pdf-elements runtime behavior

bb8658f

Signed-off-by: Phillip <phillipxh@gmail.com>

test(mobile): increase coverage for signature placement flows

d4f371f

Signed-off-by: Phillip <phillipxh@gmail.com>

fix(mobile): restore sign flow fallback for self-signer requests

217532d

Signed-off-by: Phillip <phillipxh@gmail.com>

test: fix PdfEditor spec runtime mock typing

67c9657

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore(deps): bump pdf-elements to 1.1.4

16732f4

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore(deps): refresh lockfile for pdf-elements

3e8be6b

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-editor): remove touchend workaround internals

e8aeb6c

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-editor): decouple model from pdf-elements type export

7b07878

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(pdf-worker): import worker setup from exported asyncReader path

b9b2129

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(pdf-editor): drop workaround-specific touchend specs

5a3e185

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(vite): remove pdf-elements runtime patch plugin

08bc316

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore(deps): bump pdf-elements to 1.1.5

0492c60

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore(deps): refresh lockfile for pdf-elements 1.1.5

96cf506

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-editor): use pdf-elements exported object type

6b223ff

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-worker): restore root setWorkerPath import

5e66415

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(sign-route): avoid stale sign_request_uuid fallback

1239608

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(sign-route): cover stale state UUID regression

91d9c73

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(pdf-editor): use theme tokens for action buttons

9b68376

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(playwright): normalize sign links to relative app paths

1edfda9

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(playwright): simplify sign-link extraction to relative path

c4086a9

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: alias pdf-elements to source in vite

b2277af

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: align pdf-elements alias in vitest

bcb90b3

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: set pdf worker path synchronously

d6c2162

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: initialize pdf worker before editor mount

5772241

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: resolve nested visible element pdf urls

453d891

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: load request signature modal pdf blobs

7e3b7d5

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: sync right sidebar open state

8fc4528

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: mark sign store mounted on selection

d72c36f

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

vitormattos added 18 commits April 5, 2026 23:20

chore: depend on pdf-elements 1.1.6

f8d92de

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore: refresh frontend lockfile

f8cfbc0

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor: simplify pdf editor add completion flow

9a41f27

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: handle pdf editor add completion event

941a028

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover pdf editor add completion flow

89d77d3

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: update visible elements add completion event

7428e74

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor: remove redundant PdfEditor lifecycle hooks

cff5b50

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: stabilize pdf editor action button colors in dark themes

4d76316

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: strengthen toolbar color override selectors

d40d1e5

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: target pdf-elements scoped toolbar selector

d9abb07

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: correct toolbar override selector nesting

dae1c72

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

style: align pdf action toolbar with Nextcloud button aesthetics

44a901c

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

feat: consume pdf-elements action styling hooks

02ec3a5

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore: bump pdf-elements dependency to 1.2.1

f86158e

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore: refresh lockfile for pdf-elements 1.2.1

b44b9a0

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

backportbot-libresign bot requested a review from vitormattos April 5, 2026 23:21

backportbot-libresign bot added the 3. to review label Apr 5, 2026

github-project-automation bot moved this to 0. Needs triage in Roadmap Apr 5, 2026

github-project-automation bot added this to Roadmap Apr 5, 2026

backportbot-libresign bot added this to the Next Patch (33) milestone Apr 5, 2026

backportbot-libresign bot assigned vitormattos Apr 5, 2026

fix: hide sign action while positioning signer

17db053

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

vitormattos force-pushed the backport/7408/stable33 branch from 6a37247 to 17db053 Compare April 5, 2026 23:26

vitormattos marked this pull request as ready for review April 5, 2026 23:26

vitormattos merged commit 0efd836 into stable33 Apr 5, 2026
69 checks passed

vitormattos deleted the backport/7408/stable33 branch April 5, 2026 23:40

github-project-automation bot moved this from 0. Needs triage to 4. to release in Roadmap Apr 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[stable33] Continue PR #7342: mobile signature placement flow#7416

[stable33] Continue PR #7342: mobile signature placement flow#7416
vitormattos merged 68 commits intostable33from
backport/7408/stable33

backportbot-libresign bot commented Apr 5, 2026 •

edited by vitormattos

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

backportbot-libresign bot commented Apr 5, 2026 • edited by vitormattos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Todo

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

backportbot-libresign bot commented Apr 5, 2026 •

edited by vitormattos

Loading