fix: improve daily reports reliability and formatting#52
Open
Daniel Beer (DanielB945) wants to merge 1 commit intomainfrom
Open
fix: improve daily reports reliability and formatting#52Daniel Beer (DanielB945) wants to merge 1 commit intomainfrom
Daniel Beer (DanielB945) wants to merge 1 commit intomainfrom
Conversation
Two key improvements to LTX daily reports: 1. Remove credit limit section from marketing report - The credit_limit_summary CTE referenced _sdc_sequence field which doesn't exist in backend_griffin_market_purchased_consumables table - Temporarily disabled to unblock report execution - Added comment noting the issue for future fix 2. Update product report template to table format - Changed from verbose bullet-point format to compact table - Each cell shows: value (DoD% / vs Week%) - Added explanation section for easier interpretation - Maintains all metrics while improving scannability These changes ensure reports run reliably and present data more effectively.
Daniel Beer (DanielB945)
requested a review
from Assaf Hay Eden (AssafHayEden)
as a code owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_sdc_sequencefield)Test Plan