Skip to content

feat: image export for mvp tables #7157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ElectricalBoy wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: image export for mvp tables #7157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed71a8f
add ID
ElectricalBoy Feb 25, 2026
041fc1b
add MvpTable selector
ElectricalBoy Feb 25, 2026
6ad5e5d
remove toggle
ElectricalBoy Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions javascript/commons/ExportImage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,13 @@ const EXPORT_IMAGE_CONFIG = {
typeName: 'Participants'
},
{ selector: '.standings-ffa', targetSelector: 'tbody', typeName: 'BR/FFA Standings Table' },
{ selector: '.standings-swiss', targetSelector: 'tbody', typeName: 'Swiss Standings Table' }
{ selector: '.standings-swiss', targetSelector: 'tbody', typeName: 'Swiss Standings Table' },
{
selector: '.table2#MvpTable',
targetSelector: '.table2__container',
titleSelector: '.table2__title',
typeName: 'MVP Table'
}
]
};

Expand Down Expand Up @@ -477,7 +483,7 @@ class ExportService {
}

removePrizepoolToggles( clonedDoc ) {
const prizepoolToggles = clonedDoc.querySelectorAll( '.ppt-toggle-expand' );
const prizepoolToggles = clonedDoc.querySelectorAll( '.ppt-toggle-expand, .prizepooltabletoggle' );

for ( const prizepoolToggle of prizepoolToggles ) {
prizepoolToggle.remove();
Expand Down
1 change: 1 addition & 0 deletions lua/wikis/commons/MvpTable.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ function MvpTable.run(args)
return TableWidgets.Table{
tableClasses = {'prizepooltable', 'collapsed'},
title = String.nilIfEmpty(args.title),
attributes = {id = 'MvpTable'},
columns = {
{align = 'left'},
{align = 'right'},
Expand Down
Loading