Skip to content

fix: Improve display for participant columns#7213

Draft
mbergen wants to merge 1 commit intomainfrom
tournamentslisting-participants
Draft

fix: Improve display for participant columns#7213
mbergen wants to merge 1 commit intomainfrom
tournamentslisting-participants

Conversation

@mbergen
Copy link
Collaborator

@mbergen mbergen commented Mar 5, 2026

Summary

Remove the css that enabled positioning multiple participants in the same row, as it introduces scrollbars.
(see https://liquipedia.net/leagueoflegends/Portal:Tournaments#Qualifiers)

This means display is worse for tournaments with larger amounts of qualified participants or otherwise shared placements:
image

Ideally we'd have this wrapping while also not introducing scroll bars, but i have no idea how to make that happen.

How did you test this change?

dev

@mbergen mbergen requested review from a team as code owners March 5, 2026 17:57
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/shrug

@Eetwalt
Copy link
Collaborator

Eetwalt commented Mar 6, 2026

Played around with it a bit to see if could get a sensible middleground:
https://liquipedia.net/commons/Module:TournamentsListing/CardList/dev/eetu1

So essentially:

  • set nowrap = false to the participant columns
  • wrap OpponentDisplays in a div with display: flex & flex-wrap: wrap & gap: 0.25rem
  • wrap each OpponentDisplay in a div with width: fit-content (as the block opponents have width: 100%, they wont wrap otherwise?)
  • set maxWidth = 30rem (or other sensible value) on the relevant columns

Still scrollbar on smaller screens, but that's intended with the new Tables anyway. But this way we can get no scrollbars on larger displays

Couldn't find your example, but looks decent for a couple participants at least.
image

@mbergen
Copy link
Collaborator Author

mbergen commented Mar 6, 2026

My example is from here: https://liquipedia.net/ageofempires/Age_of_Empires_II/Qualifier_Tournaments

The issue with your solution is that the amount of opponents per row varies based on length of their name, which is very hard to read when there's more than a handful.
Do you have ideas on how we could make the grid display that was previously/is currently used make look not that weird?

@Eetwalt
Copy link
Collaborator

Eetwalt commented Mar 6, 2026

My example is from here: https://liquipedia.net/ageofempires/Age_of_Empires_II/Qualifier_Tournaments

The issue with your solution is that the amount of opponents per row varies based on length of their name, which is very hard to read when there's more than a handful. Do you have ideas on how we could make the grid display that was previously/is currently used make look not that weird?

How about we keep the original multi-column layout for participants, but truncate the tournament column on smaller screens?
https://liquipedia.net/ageofempires/User:Eetwalt

This test makes sure the column is 15rem minimum, but grows if space allows. Also made the table width: 100%, so not sure if these tables are used in layouts this doesn't work

@mbergen
Copy link
Collaborator Author

mbergen commented Mar 6, 2026

That would be fine be me.
Making them 100% would also match the previous behavior, however display is a bit bad on pages with infoboxes as the table gets pushed down (e.g. https://liquipedia.net/ageofempires/T90_Titans_League).
This was the case with the old design on firefox before tho, at least chrome sometimes managed to display the table besides the infobox unless for very long tournament names.

@mbergen mbergen marked this pull request as draft March 11, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants