Conversation
hjpalpha
left a comment
There was a problem hiding this comment.
do we need to update Lua-Modules/javascript/Main.js?
@FO-nTTaX knows better, but I think we have this logic as part of |
yeah I thought about it. I actually started editing Main.js before making this PR, but I wasn't sure what that all means for the testing flow since I didn't set that up, and also didn't have the time to double check it. I have no strong opinion here, whatever works for the people who contribute here more than me I guess. |
|
👍 Should go into Main.js and some of the code there can be nuke with this |
javascript/Main.js
Outdated
| }; | ||
|
|
||
| // Mock MediaWiki APIs for testing | ||
| window.mw = window.mw || { |
There was a problem hiding this comment.
I think the mw mock needs to be before CoreEnd.js is included, or the files will be initialized before the mock exists and fail
There was a problem hiding this comment.
I made that change in the branch
Summary
As of Liquipedia/ResourceLoaderArticles@9b61784 these three new files are treated like all other on-wiki js files. This PR adds them to the repo with the rest of the files.