Skip to content

js(core): add missing js files#7233

Open
FO-nTTaX wants to merge 3 commits intomainfrom
add-missing-js-files
Open

js(core): add missing js files#7233
FO-nTTaX wants to merge 3 commits intomainfrom
add-missing-js-files

Conversation

@FO-nTTaX
Copy link
Member

Summary

As of Liquipedia/ResourceLoaderArticles@9b61784 these three new files are treated like all other on-wiki js files. This PR adds them to the repo with the rest of the files.

@FO-nTTaX FO-nTTaX requested review from a team as code owners March 10, 2026 13:37
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to update Lua-Modules/javascript/Main.js?

@hjpalpha hjpalpha added the javascript Changes to JavaScript files label Mar 10, 2026
@Eetwalt
Copy link
Collaborator

Eetwalt commented Mar 10, 2026

do we need to update Lua-Modules/javascript/Main.js?

@FO-nTTaX knows better, but I think we have this logic as part of Main.js already (atleast the Core.js part) and the other two files probably not relevant to testing?

@FO-nTTaX
Copy link
Member Author

do we need to update Lua-Modules/javascript/Main.js?

@FO-nTTaX knows better, but I think we have this logic as part of Main.js already (atleast the Core.js part) and the other two files probably not relevant to testing?

yeah I thought about it. I actually started editing Main.js before making this PR, but I wasn't sure what that all means for the testing flow since I didn't set that up, and also didn't have the time to double check it. I have no strong opinion here, whatever works for the people who contribute here more than me I guess.

@Rathoz
Copy link
Collaborator

Rathoz commented Mar 11, 2026

👍

Should go into Main.js and some of the code there can be nuke with this

@Rathoz Rathoz requested a review from Eetwalt March 11, 2026 11:07
};

// Mock MediaWiki APIs for testing
window.mw = window.mw || {
Copy link
Member Author

@FO-nTTaX FO-nTTaX Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the mw mock needs to be before CoreEnd.js is included, or the files will be initialized before the mock exists and fail

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made that change in the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Changes to JavaScript files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants