Skip to content

feat(match2): new results labels#7237

Open
ElectricalBoy wants to merge 4 commits intomainfrom
results-label
Open

feat(match2): new results labels#7237
ElectricalBoy wants to merge 4 commits intomainfrom
results-label

Conversation

@ElectricalBoy
Copy link
Collaborator

@ElectricalBoy ElectricalBoy commented Mar 11, 2026

Summary

This PR adds new results labels.

How did you test this change?

sandbox + browser dev tools

image image

@ElectricalBoy ElectricalBoy requested review from a team as code owners March 11, 2026 14:31
@ElectricalBoy ElectricalBoy added c: match2 stylesheets Changes to stylesheets labels Mar 11, 2026
@hjpalpha
Copy link
Collaborator

@mbergen
Copy link
Collaborator

mbergen commented Mar 11, 2026

What has design to say about this? :D

@Eetwalt
Copy link
Collaborator

Eetwalt commented Mar 11, 2026

What has design to say about this? :D

This was requested by design, these W/L labels are going to be widely adopted to other places too, such as #7170

border-radius: 0.25rem;
font-family: "Open Sans", sans-serif;
font-size: 0.6875rem;
line-height: 1rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Copy link
Collaborator Author

@ElectricalBoy ElectricalBoy Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did some math and line-height would be 0.5px off from spec without it 😛

@ElectricalBoy
Copy link
Collaborator Author

non team: https://liquipedia.net/starcraft2/HomeStory_Cup/28#Results

image

team: https://liquipedia.net/starcraft2/World_Team_League/2023/Summer#Results

after 36b4193
image

@ElectricalBoy ElectricalBoy requested a review from Eetwalt March 11, 2026 15:44
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to add badges for FF/DQ too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: match2 stylesheets Changes to stylesheets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants