Update gol match URL from '/page-game/' to '/page-summary/'#7521
Open
Idris1401 wants to merge 1 commit into
Open
Update gol match URL from '/page-game/' to '/page-summary/'#7521Idris1401 wants to merge 1 commit into
Idris1401 wants to merge 1 commit into
Conversation
hjpalpha
reviewed
May 15, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
why is that change wanted/needed?
codewise okay
Contributor
Author
to link to the match page of the series instead of just the page of one game |
Collaborator
|
wouldn't this break current usage? |
Contributor
Author
|
nope as the game id can be used for page summaries to have an overview of the series exemples: |
Collaborator
|
is this discussed with (and approved by) the contributors of the wikis that use this param? |
Contributor
Author
I was told by @ElectricalBoy "feel free to pr" |
ElectricalBoy
added
g: leagueoflegends
ElectricalBoy
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?