Moving the prize-pool and navigation-card colors logic#7535
Open
JuJinPark wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves theme-specific CSS custom property definitions for prize pool tables and navigation card icons from the Lakesideview skin into the shared Lua-Modules stylesheet set, as part of ongoing CSS cleanup/centralization.
Changes:
- Added theme-scoped (
html.theme--light/html.theme--dark)--prize-pool-*custom properties inPrizepooltable.scss. - Added theme-scoped
--navigation-card-icon-*custom properties inNavigationCard.scss.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| stylesheets/commons/Prizepooltable.scss | Introduces theme-specific --prize-pool-* variables to control prize pool table colors via CSS custom properties. |
| stylesheets/commons/NavigationCard.scss | Introduces theme-specific --navigation-card-icon-* variables for navigation card icon styling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ElectricalBoy
added
c: prize_pool
stylesheets
ElectricalBoy
approved these changes
May 22, 2026
… for navigation and prize pool components
JuJinPark
force-pushed
the
feature/move-prize-pool-naviation-card
branch
from
e5e60bf to
50bb56f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moving the prize-pool and navigation-card colors logic from the Lakesideview repo to the Lua-Modules repo.
This is part of the CSS cleanup task, similar to what was done in this PR:#7479
Related MR
How did you test this change?
Deployed to my dev wiki (lakesideview + Lua-Modules changes):
(https://mediawiki.wiki.tldev.eu/rocketleague/Rival_Rush/Season_2/Split_2) — verified all eight --prize-pool-* custom
properties resolve to identical values on both, in light and dark themes. Visually identical.
resolve to identical values in light and dark themes. No visual diff possible: because couldn't find a rocketleague page that render the .navigation-card__icon variant .