Skip to content

perf: optimize Array.interleave implementation #7536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ElectricalBoy wants to merge 3 commits into
base: main
Choose a base branch
from
Open

perf: optimize Array.interleave implementation #7536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b16c63
rewrite Array.interleave
ElectricalBoy May 21, 2026
5f50634
more test cases
ElectricalBoy May 21, 2026
9862ae2
another test case
ElectricalBoy May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lua/spec/array_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,13 @@ describe('array', function()
describe('Interleave', function ()
it('works', function()
assert.are_same({'a', ' ', 'b', ' ', 'c'}, Array.interleave({'a', 'b', 'c'}, ' '))
assert.are_same({'a'}, Array.interleave({'a'}, ' '))
assert.are_same({}, Array.interleave({}, ' '))
end)

it('with nested array', function ()
local a, b = Array.range(1, 3), math.pi
assert.are_same({{1, 2, 3}, ' ', b}, Array.interleave({a, b}, ' '))
end)
end)
end)
13 changes: 6 additions & 7 deletions lua/wikis/commons/Array.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,13 +727,12 @@ end
---@param x T
---@return (V|T)[]
function Array.interleave(elements, x)
local size = #elements
return Array.flatMap(elements, function(element, index)
if index == size then
return {element}
end
return {element, x}
end)
local ret = {elements[1]}
for i = 2, #elements do
table.insert(ret, x)
table.insert(ret, elements[i])
end
return ret
end

return Array
Loading