Conversation
Eetwalt
changed the title
hjpalpha
approved these changes
May 21, 2026
Collaborator
hjpalpha
left a comment
hjpalpha
left a comment
There was a problem hiding this comment.
lgtm
imo post an info in that resp discord channel so they are aware that they should not use s/h in the new TP templates :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Module:TeamCard/Legacy/Customfor identityv to bridge the oldposNarg convention to the new wrapper'spNposshape, and normalize theS/Hshorthand tosurvivor/hunterso role icons resolve viaModule:InGameRolesandPOSITION_ICON_DATA.Module:TeamCard/Legacyto also pick up the barec=coach key. Previously only indexed slotsc1..c10were scanned, so wikitext like|c=Alice|c2=Bobrendered only Bob, and|c=Alicerendered no coach at all.Template:TeamCard columns endto invokemodule=TeamCard/Legacy/Custom|fn=runonce the wrapper rollout happens.How did you test this change?
dev + currently live in prod for identityv