refactor: clean up SearchLVTest#3163
Merged
Ziinc merged 5 commits intoLogflare:mainfrom Feb 20, 2026
Merged
Conversation
msmithstubbs
force-pushed
the
test/clean-up-search-lv-test
branch
6 times, most recently
from
cc12cc8 to
13d8a43
Compare
msmithstubbs
commented
Feb 17, 2026
| ConsolidatedSup.stop_pipeline(backend.id) | ||
| catch | ||
| value -> value | ||
| end |
Contributor
Author
There was a problem hiding this comment.
This cleanup kept throwing an exception and causing CI to fail.
msmithstubbs
force-pushed
the
test/clean-up-search-lv-test
branch
2 times, most recently
from
7951536 to
f31cdad
Compare
msmithstubbs
changed the title
Ziinc
approved these changes
Feb 19, 2026
Contributor
Ziinc
left a comment
Ziinc
left a comment
There was a problem hiding this comment.
@msmithstubbs can you remove the $callers update? other logic looks good.
| def init(args) do | ||
| source = Keyword.get(args, :source) | ||
| callers = Keyword.get(args, :callers) | ||
| Process.put(:"$callers", callers) |
Contributor
There was a problem hiding this comment.
not a fan of manipulating the process dictionary directly for this since it is subject to otp internal changes.
don't think we need to update it either since it isn't used in any further logic
Contributor
Author
There was a problem hiding this comment.
Removed this and restored the Sandbox.allow/4 calls
msmithstubbs
force-pushed
the
test/clean-up-search-lv-test
branch
from
f31cdad to
1f42a6f
Compare
msmithstubbs
force-pushed
the
test/clean-up-search-lv-test
branch
from
1f42a6f to
b3a7b67
Compare
This reverts commit b3a7b67.
Ziinc
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up a few things in SearchLVTest, including feedback from #3145
retry_assert/1sleep/1withwait_for_render/1in SearchLVTest. Eliminates around 10 seconds