chore: remove warnings related to distinct types for compile time config vars#3166
Open
nelsonmestevao wants to merge 1 commit intoLogflare:mainfrom
Open
chore: remove warnings related to distinct types for compile time config vars#3166nelsonmestevao wants to merge 1 commit intoLogflare:mainfrom
nelsonmestevao wants to merge 1 commit intoLogflare:mainfrom
Conversation
nelsonmestevao
force-pushed
the
ne/warns
branch
6 times, most recently
from
d07f806 to
7e3ea34
Compare
nelsonmestevao
force-pushed
the
ne/warns
branch
from
7e3ea34 to
4a3a9bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were happening because the type checker can validate the values at compile time and finds them always false. However, that is not true at other environments (other than dev and test).