feat: oban scheduler for alerts, enable/disable, execution history#3167
Merged
feat: oban scheduler for alerts, enable/disable, execution history#3167
Conversation
Ziinc
changed the title
Ziinc
changed the title
Ziinc
force-pushed
the
feat/oban-scheduler
branch
from
f236c6c to
f3d2aee
Compare
Ziinc
force-pushed
the
feat/oban-scheduler
branch
from
31bbe35 to
3ab1304
Compare
Contributor
Author
|
will be merging this in first to get it over with |
josevalim
reviewed
Feb 27, 2026
Contributor
josevalim
left a comment
josevalim
left a comment
There was a problem hiding this comment.
It looks great to me, just two minor comments.
I have to say: it is really nice that we can just emit regular queries when we need to manipulate existing Oban jobs!
Comment on lines
+22
to
+23
| <td :for={col <- Map.keys(hd(@query_result_rows))}> | ||
| <% val = Map.get(row, col) %> |
Contributor
There was a problem hiding this comment.
Do you still need to do the Map.keys dance or could you traverse on the values directly?
Suggested change
| <td :for={col <- Map.keys(hd(@query_result_rows))}> | |
| <% val = Map.get(row, col) %> | |
| <td :for={{col, val} <- row}> |
| end | ||
|
|
||
| defp truncate_reason(reason, _max_length) when is_binary(reason), do: reason | ||
| defp truncate_reason(reason, max_length), do: truncate_reason(inspect(reason), max_length) |
Contributor
There was a problem hiding this comment.
It may be worth extracting some of these helpers (truncate_reason, format_bytes, time_ago) into a separate module for unit testing in a future commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in the following:
Prod setup remains the same, alerts is still maintained and functioning in only one cluster.
Part of O11Y-321
Closes O11Y-1461
Closes O11Y-195