fix non conventions based SentryLog engine#58
Merged
Conversation
LordSimal
force-pushed
the
3.x-log-engine-naming
branch
from
9360a49 to
2cea16a
Compare
Owner
Author
|
@ADmad looks good? |
ADmad
reviewed
Apr 6, 2026
| $sentryLogger->flush(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
class_alias() call missing at the bottom of the file, similar to https://github.com/cakephp/cakephp/blob/5.next/src/Console/Helper/BannerHelper.php#L110
LordSimal
force-pushed
the
3.x-log-engine-naming
branch
from
2cea16a to
2e1317c
Compare
ADmad
reviewed
Apr 6, 2026
| { | ||
| public bool $logsWillBeFlushed = false; | ||
| $msg = 'Use `CakeSentry\Log\Engine\SentryLog` instead of `CakeSentry\Log\Engines\SentryLog`.'; | ||
| deprecationWarning('3.5.3', $msg); |
There was a problem hiding this comment.
People usually don't like explicit deprecation warnings in a patch release.
Owner
Author
There was a problem hiding this comment.
Then people can complain about that to me 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57