Conversation
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-PROTOBUF-15090738 - https://snyk.io/vuln/SNYK-PYTHON-ZIPP-7430899
There was a problem hiding this comment.
Pull request overview
This PR addresses security vulnerabilities identified by Snyk in two transitive dependencies: protobuf (upgrading from 3.20.1 to 6.33.5) and zipp (upgrading from 3.15.0 to 3.19.1). These dependencies are not directly used by the application but are required by packages like onnx, onnxruntime, streamlit, and transformers.
Changes:
- Added explicit version constraints for protobuf (>=6.33.5) to fix vulnerability SNYK-PYTHON-PROTOBUF-15090738
- Added explicit version constraints for zipp (>=3.19.1) to fix vulnerability SNYK-PYTHON-ZIPP-7430899
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| protobuf>=6.33.5 # not directly required, pinned by Snyk to avoid a vulnerability | ||
| zipp>=3.19.1 # not directly required, pinned by Snyk to avoid a vulnerability No newline at end of file |
There was a problem hiding this comment.
Using ">=" for these security-pinned dependencies is inconsistent with the rest of the requirements file, where all other dependencies use exact version pinning with "==". This creates unpredictability in the build environment. Consider using "==" to pin to specific versions (e.g., "protobuf==5.28.3" and "zipp==3.19.1") to maintain consistency and ensure reproducible builds.
| protobuf>=6.33.5 # not directly required, pinned by Snyk to avoid a vulnerability | |
| zipp>=3.19.1 # not directly required, pinned by Snyk to avoid a vulnerability | |
| protobuf==6.33.5 # not directly required, pinned by Snyk to avoid a vulnerability | |
| zipp==3.19.1 # not directly required, pinned by Snyk to avoid a vulnerability |
| diffusers==0.4.0 | ||
| torch==1.10.0+cpu No newline at end of file | ||
| torch==1.10.0+cpu | ||
| protobuf>=6.33.5 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
The PR description shows warnings that multiple dependencies require protobuf but it's "not installed": transformers 4.22.2, streamlit 1.13.0, onnxruntime 1.12.1, and onnx 1.12.0. This suggests that upgrading protobuf to a much newer version (from 3.20.1 to 6.x/5.x) may introduce compatibility issues with these older packages. These packages were released in 2022 and likely expect protobuf 3.x. Before merging, verify that the new protobuf version is compatible with onnx==1.12.0, onnxruntime==1.12.1, streamlit==1.13.0, and transformers==4.22.2, or consider upgrading these dependencies as well.
Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
docker/requirements.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.