chore(devnet): add upgrade rehearsal targets v1.11.0/v1.11.1/v1.12.0 (cherry-pick of #133)#138
Merged
mateeullahmalik merged 1 commit intoMay 11, 2026
Conversation
Add Makefile.devnet targets for the 3 missing rehearsal versions, matching the existing pattern (devnet-upgrade-180/191/1100/1101). Also normalize devnet-upgrade-1101 binaries-dir from ../bin to ../bin-v1.10.1 to match the per-version convention used by every other target. Verified locally: ran devnet-upgrade-1120 end-to-end against v1.11.1-hotfix FROM_TAG. Chain halted at upgrade height 116, swapped binaries, and resumed block production on the v1.12.0 binary. 'lumerad query upgrade applied v1.12.0' returns height 116 confirming the upgrade handler ran. Note: bin-v1.X.Y/ directories are operator-staged (not shipped in repo), matching the existing convention for all 4 prior targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #133 (master commit
be1212c9/ squash59eaf74e) onto the1.12.0release branch.Behavior change
Adds three
Makefile.devnettargets matching the existing per-version pattern (this branch still uses the pre-#108 explicit-target convention, so the original commit applies cleanly):Also normalizes
devnet-upgrade-1101from../bin→../bin-v1.10.1to match the per-version convention used by every other target.Why backport
Every devnet rehearsal must have a local devnet target. Upgrade handlers
app/upgrades/v1_11_0,v1_11_1,v1_12_0all exist on1.12.0— verified — but the corresponding rehearsal targets did not, which is the exact gap #133 closed on master.Cherry-pick mechanics
git cherry-pick be1212c9), single Makefile.devnet auto-merge, no conflicts.origin/1.12.0: 1 file, +11/-2 — byte-identical to original chore(devnet): add upgrade rehearsal targets v1.11.0 / v1.11.1 / v1.12.0 #133 commit on master.1.12.0predates Cosmos EVM Integration #108 (Cosmos EVM Integration) which refactored the rehearsal targets into a parameterizeddevnet-upgrade-version VERSION=…framework on master. The explicit-target shape here is correct for this branch.Local rehearsal evidence (from #133)
Original PR ran
devnet-upgrade-1120end-to-end againstv1.11.1-hotfixFROM_TAG: chain halted at upgrade height 116, swapped binaries, resumed block production on v1.12.0;lumerad query upgrade applied v1.12.0returnedheight: "116". Call paths are identical on this branch.Risks
None. Pure additive Makefile change. The 1101 normalization fixes a pre-existing inconsistency and only affects which binary directory is required to exist when that target is invoked.
Rollback
git revert— Makefile-only.Operator notes
bin-v1.X.Y/directories are operator-staged (not shipped in repo), matching existing convention.