Skip to content

Conversation

@akobrin1
Copy link
Contributor

  • Add TestICARequestActionAppPubkeyRequired and refactor the ICA hermes suite (renamed files, clearer flow/comments, use sdk-go/pkg/crypto helpers)
  • Update devnet module deps to lumera v1.9.1, sdk-go v1.0.5, supernode v2.4.19, and document local replace toggles
  • Promote golang/mock to a direct dependency and fix gomock import in unbonding_test.go

@roomote
Copy link

roomote bot commented Jan 10, 2026

Rooviewer Clock   See task on Roo Cloud

Review complete. No issues found.

The changes look good:

  • New TestICARequestActionAppPubkeyRequired test properly validates app_pubkey requirements for ICA requests
  • Refactoring to use sdk-go/pkg/crypto helpers removes code duplication
  • File renames improve clarity (ibc_hermes_* -> ibc_*)
  • Dependency updates to lumera v1.9.1, sdk-go v1.0.5, and supernode v2.4.19 are straightforward version bumps
  • Promoting golang/mock to direct dependency and fixing the import in unbonding_test.go is correct

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@akobrin1 akobrin1 merged commit da7d862 into master Jan 10, 2026
8 checks passed
@akobrin1 akobrin1 deleted the ica-tests branch January 10, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants