Skip to content

Conversation

@akobrin1
Copy link
Contributor

@akobrin1 akobrin1 commented Jan 15, 2026

This PR ensures supernode SDK always uses Lumera bech32 addresses for secure transport identities and signer defaults, independent of global SDK config.

  • Added GetBech32Address helper in supernode/pkg/keyring with unit test.
  • Use Lumera HRP in factory.go.
  • Use Lumera HRP in impl.go with injectable newClientCreds; add test to verify LocalIdentity.
  • Use Lumera HRP in client.go with injectable newLumeraAdapter; add test to verify signerAddr normalization.
  • validateDownloadAction now accepts ACTION_STATE_APPROVED in addition to ACTION_STATE_DONE - so that approved actions can be downloaded as well.

@roomote
Copy link

roomote bot commented Jan 15, 2026

Rooviewer Clock   See task on Roo Cloud

Reviewed all 9 changed files. No issues found.

The PR correctly enforces Lumera HRP for supernode signer identity across all SDK components with good test coverage.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@akobrin1 akobrin1 merged commit 7ee310b into master Jan 15, 2026
7 checks passed
@akobrin1 akobrin1 deleted the sdk-lumera-hrp branch January 15, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants