Skip to content

Add MITL branding elements and match navigation as close as possible.#26

Open
djanelle-mit wants to merge 7 commits intomit-mainfrom
dave-exploration
Open

Add MITL branding elements and match navigation as close as possible.#26
djanelle-mit wants to merge 7 commits intomit-mainfrom
dave-exploration

Conversation

@djanelle-mit
Copy link

Why these changes are being introduced

The out of the box NDE experience doesn't align with MITL branding.

How this addresses that need

This work introduces relevant header, footer, and search components that are as close as possible to intended design system components. This includes:

  • Institute bar across the top of the page.
  • Styled navigation to be as close as possible to MITL navigation. Note: the logo still needs updating.
  • Styled search boxes to be closer to the USE search component.
  • Added MITL and Institute footers.
  • Responsive behavior for these elements.

Side effects of this change

Not noticed on my end, but definitely worth double-checking.

Relevant ticket(s)

Copy link

@adamshire123 adamshire123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic. Thanks!

A couple of things I noticed:

At a window width of 670px (in Brave dev tools) the language selector dropdown starts colliding with the "MORE" menu item.

After performing a search, on the search results page, the search box and search profile selector lose their border, making them hard to pick out. There is also a grey vertical bar just to the left side of the red search button. this appears as a separator between the "X (clear search)" and the magnifying glass search button in the un-customized view

Image

@djanelle-mit
Copy link
Author

@adamshire123 I seem to have the search box styling fixed on that child page now.

The menu wrapping was caused by my font size increase... whatever Javascript they're using to proactively hide the menu items is thrown off by the larger size of the larger text. I'm going to revert that to the original size for now.

Would you mind taking another look at this when you get a chance? I'd love to hammer out any bugs, get this merged, and see how it looks with the logo swapped out before making another round of changes.

@adamshire123
Copy link

image

Do these navigation buttons need more contrast?

@djanelle-mit
Copy link
Author

@adamshire123 Yep, those icons happened to be included in my bugfix where I was overriding the color of icons too globally. Should be all set now.

Logo is in place, too, so I'd love another set of eyes on this one!

Copy link

@adamshire123 adamshire123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dave,
Thanks for these updates. This all looks really great.

We should get a favicon in there eventually. It needs to be a .svg file at the path src/assets/icons/favicon.ico

I'll leave it up to you if you want to add that now, or merge this PR now and save that favicon for another time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants