Skip to content

Simplify dead HP preservation to explicit zero#665

Merged
AngeloTadeucci merged 1 commit intomasterfrom
dead-hp-explicit-zero
Mar 6, 2026
Merged

Simplify dead HP preservation to explicit zero#665
AngeloTadeucci merged 1 commit intomasterfrom
dead-hp-explicit-zero

Conversation

@AngeloTadeucci
Copy link
Collaborator

Stat rebuild via AddBase/AddTotal restores Current to Total, but a dead player must stay at 0 HP until revived. Set HP explicitly to 0 instead of preserving the previous value.

Stat rebuild via AddBase/AddTotal restores Current to Total, but a dead
player must stay at 0 HP until revived. Set HP explicitly to 0 instead
of preserving the previous value.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

Warning

Rate limit exceeded

@AngeloTadeucci has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 37 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6b3c4446-0b11-47b5-80f4-6635c9afcdb0

📥 Commits

Reviewing files that changed from the base of the PR and between 6590f86 and eea8736.

📒 Files selected for processing (1)
  • Maple2.Server.Game/Manager/StatsManager.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dead-hp-explicit-zero

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AngeloTadeucci AngeloTadeucci merged commit 289770c into master Mar 6, 2026
3 checks passed
@AngeloTadeucci AngeloTadeucci deleted the dead-hp-explicit-zero branch March 6, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant