Fix crash from weapons dropped from monsters#363
Open
greatguys1 wants to merge 1 commit intoMSRevive:devfrom
Open
Fix crash from weapons dropped from monsters#363greatguys1 wants to merge 1 commit intoMSRevive:devfrom
greatguys1 wants to merge 1 commit intoMSRevive:devfrom
Conversation
Fixes calruin2 crash
Contributor
|
Looks good to me.
…On Tue, 10 Mar 2026 at 15:51, greatguys1 ***@***.***> wrote:
Fixes calruin2 crash.
Weapon would try to reference calrian's despawned corpse, referencing
memory that didn't belong to it.
------------------------------
You can view, comment on, or merge this pull request online at:
#363
Commit Summary
- c84ac50
<c84ac50>
Fix crash from weapons dropped from monsters
File Changes
(1 file <https://github.com/MSRevive/MasterSwordRebirth/pull/363/files>)
- *M* src/game/shared/weapons/giattack.cpp
<https://github.com/MSRevive/MasterSwordRebirth/pull/363/files#diff-446878e6437d734c3603f808191c6737943894f45e08e3c67c5c525d091e7ee1>
(2)
Patch Links:
- https://github.com/MSRevive/MasterSwordRebirth/pull/363.patch
- https://github.com/MSRevive/MasterSwordRebirth/pull/363.diff
—
Reply to this email directly, view it on GitHub
<#363>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA34IYRHVGLBOEZNA3TI4V34P6UOZAVCNFSM6AAAAACWMU5DROVHI2DSMVQWIX3LMV43ASLTON2WKOZUGA2DSNJXHA2TKMA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes calruin2 crash.
Weapon would try to reference calrian's despawned corpse, referencing memory that didn't belong to it.