Rename '.cocoscript' to '.cocoascript' #7
Open
bysqtr wants to merge 4 commits intoMagicSketch:masterfrom
bysqtr:master
Open
Rename '.cocoscript' to '.cocoascript' #7bysqtr wants to merge 4 commits intoMagicSketch:masterfrom bysqtr:master
bysqtr wants to merge 4 commits intoMagicSketch:masterfrom
bysqtr:master
Conversation
added 4 commits
August 31, 2017 16:04
The script file has the incorrect extension of 'script.cocoscript' as well as the references to it in the plist and manifest. Although the project compiles and runes just fine in Xcode, I though it'd be appropriate to correct the extension to it's proper 'script.cocoascript'.
Delete script.cocoscript
Correct extension from '.cocoscript' to '.cocoascript'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw that the 'script.cocoscript' was (as you can see) incorrectly named to what it should be as 'script.cocoascript.' Thought I'd correct it, with the the file itself and the references to it in 'TemplateInfo.plist' and 'manifest.json' corrected with the right extension spelling.