fix: replace ArrayStyle with PeriodicArrayStyle for correct broadcast dispatch#7
Merged
AFeuerpfeil merged 2 commits intomainfrom Mar 31, 2026
Merged
fix: replace ArrayStyle with PeriodicArrayStyle for correct broadcast dispatch#7AFeuerpfeil merged 2 commits intomainfrom
AFeuerpfeil merged 2 commits intomainfrom
Conversation
… dispatch
The old `ArrayStyle{PeriodicArray{T,N,A,F}}` approach broke on scalar-first
broadcasts and mixed-type PA operations because `bc.args[1].map` assumed a
specific arg layout and `ArrayStyle` erased the array type info needed for
style promotion. Introducing `PeriodicArrayStyle{N} <: AbstractArrayStyle{N}`
with explicit promotion rules and a helper `_find_pa` to recover the map
from any broadcast tree fixes these cases. Bump version to 1.1.1.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Broadcast.ArrayStyle{PeriodicArray{T,N,A,F}}with a newPeriodicArrayStyle{N} <: AbstractArrayStyle{N}carrying dimensionality with proper style promotion rules._find_pahelper to recover thePeriodicArray(and its.map) from anywhere in a broadcast argument tree, fixing the fragilebc.args[1].mapassumption.1 .+ pa), mixed-element-type PA operations, and PA-with-plain-array broadcasts that previously errored or silently returned a plainArray.