MDEV-39691 wsrep.cnf contains deprecated wsrep_causal_reads#5104
Open
grooverdan wants to merge 2 commits into
Open
MDEV-39691 wsrep.cnf contains deprecated wsrep_causal_reads#5104grooverdan wants to merge 2 commits into
grooverdan wants to merge 2 commits into
Conversation
grooverdan
added
the
MariaDB Foundation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the wsrep.cnf.sh configuration file by replacing references to 'mysqld' with 'mariadb' and 'mariadbd' to reflect the transition to MariaDB. It also removes the wsrep_causal_reads configuration option. A review comment correctly identifies a spelling error in a modified comment line and provides a suggestion to fix it.
janlindstrom
requested changes
May 21, 2026
Contributor
janlindstrom
left a comment
janlindstrom
left a comment
There was a problem hiding this comment.
ok to remove wsrep_causal_read but add wsrep_sync_wait
wsrep_causal_reads was deprecated in 10.1.3 and removed in 11.3.1. Put in place the equivalent (and default) wsrep_sync_wait=0. Amend a few early comments to show MariaDB as our product.
janlindstrom
requested changes
May 21, 2026
Contributor
janlindstrom
left a comment
janlindstrom
left a comment
There was a problem hiding this comment.
There is now merge <<<<< HEAD tags
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Member
|
@janlindstrom is enough, I removed myself from reviewers |
Member
Author
|
@janlindstrom if you've got 10.6 push access can you trigger the upgrade branch/automerge as I'm unable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wsrep_causal_reads was deprecated in 10.1.3 and removed in 11.3.1.
Remove it out of the configuration file in the earliest supported version as config file are kept on upgrade.
Amend a few early comments to show MariaDB as our product.