MDEV-31209 Queries with window functions do not obey KILL / max_statement_time#5126
Open
grooverdan wants to merge 1 commit into
Open
MDEV-31209 Queries with window functions do not obey KILL / max_statement_time#5126grooverdan wants to merge 1 commit into
grooverdan wants to merge 1 commit into
Conversation
grooverdan
added
the
MariaDB Foundation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes MDEV-31209 by ensuring queries with window functions respect KILL and max_statement_time limits. It adds a check for current_thd->check_killed(true) in the Frame_scan_cursor loop in sql/sql_window.cc and includes corresponding test cases. The review feedback suggests caching current_thd in a local variable before the loop to avoid thread-local storage (TLS) lookup overhead on every iteration.
…ment_time Window functions run in a loop in Frame_cursor::compute_values_for_current_row which can include a large number of rows. Adjust this function to check for the current thd being killed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Window functions run in a loop in
Frame_cursor::compute_values_for_current_row which can include a large number of rows.
Adjust this function to check for the current thd being killed.