Re-added support for 'Jump to Cursor' command#1227
Open
basit-s wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores Jump to Cursor behavior and aligns the adapter with expected DAP request flow, see Issue #1226
I found the original feature implementation for 'Jump to Cursor' in PR #417 and Issue #418, but it seems to have been broken during a refactor in commit 1ff878c.
Current master still advertises supportsGotoTargetsRequest, and the changelog still says Jump to Cursor is supported, but I cannot find a gotoRequest implementation in the adapter anymore, and the MI backend no longer has the exec-jump path that PR #417 added. So this looks like a partial DAP implementation now: gotoTargetsRequest exists, but the actual goto step appears to be missing. When running the code, Jump to Cursor returns the error message shown in the image below.