resolver.ResolveLocal: fully dereference basedir before walking#883
Open
drafnel wants to merge 1 commit intoMasterminds:masterfrom
Open
resolver.ResolveLocal: fully dereference basedir before walking#883drafnel wants to merge 1 commit intoMasterminds:masterfrom
drafnel wants to merge 1 commit intoMasterminds:masterfrom
Conversation
Commit 52f7192 taught NewResolver to detect when the basedir argument is a symlink and to extract the target of the symlink and use it in place of the original basedir. This works correctly and allows ResolveLocal to walk the directory tree when the symlink target is a fully qualified path to a directory. But, if the symlink points to another symlink, or if it provides a relative path, then the traversal by filepath.Walk() will fail as before. The path/filepath package already provides a function to fully evaluate a path and dereference any symbolic links: filepath.EvalSymlinks(). So instead of using checkForBasedirSymlink() to perform a single dereference of basedir and storing that into the Resolver object, let's just record the original path into the Resolver object and then call filepath.EvalSymlinks() to fully resolve the path in ResolveLocal before walking the tree with filepath.Walk().
Author
|
Ping. Hi @mattfarina can you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 52f7192 taught NewResolver to detect when the basedir argument is
a symlink and to extract the target of the symlink and use it in place
of the original basedir. This works correctly and allows ResolveLocal
to walk the directory tree when the symlink target is a fully qualified
path to a directory. But, if the symlink points to another symlink, or
if it provides a relative path, then the traversal by filepath.Walk()
will fail as before.
The path/filepath package already provides a function to fully evaluate
a path and dereference any symbolic links: filepath.EvalSymlinks().
So instead of using checkForBasedirSymlink() to perform a single
dereference of basedir and storing that into the Resolver object, let's
just record the original path into the Resolver object and then call
filepath.EvalSymlinks() to fully resolve the path in ResolveLocal before
walking the tree with filepath.Walk().