Conversation
stefanmaric
requested changes
Feb 4, 2025
Member
stefanmaric
left a comment
stefanmaric
left a comment
There was a problem hiding this comment.
Looking good overall. Before merging, let's:
Rollback the package-lock.json changes and install again making sure of using the npm version bundled with node 18 LTS as declared here: https://github.com/MasterworksIO/action-slacksync/blob/master/package.json#L8
This to avoid the big changes in the lock file itself and the transitive dependencies.
We actually should have added the packageManager field with corepack a while back. Let's skip it for now.
The other thing is to add an item on the CHANGELOG. Example: e0981ff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.