adapter: rename staged_cancellation to connection_cancel_watches#36631
Open
aljoscha wants to merge 1 commit into
Open
adapter: rename staged_cancellation to connection_cancel_watches#36631aljoscha wants to merge 1 commit into
aljoscha wants to merge 1 commit into
Conversation
The map of per-connection cancel watch channels was named for its historical sole consumer (staged sequencing in `sequence_staged` / `handle_spawn`), but the mechanism itself is generic: any code path that wants a connection-scoped "has this been cancelled?" signal can install/remove an entry. `handle_privileged_cancel` already pokes the sender from outside the staged path. Rename the field to `connection_cancel_watches` and rewrite the doc comment to describe the abstraction (a per-connection watch consumed by whatever has cancellable work in flight) rather than naming a single caller. Also tighten the docs on `sequence_staged` / `handle_spawn` to point at the renamed map. Work towards MaterializeInc/database-issues#6686 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The map of per-connection cancel watch channels was named for its historical sole consumer (staged sequencing in
sequence_staged/handle_spawn), but the mechanism itself is generic: any code path that wants a connection-scoped "has this been cancelled?" signal can install/remove an entry.handle_privileged_cancelalready pokes the sender from outside the staged path.Rename the field to
connection_cancel_watchesand rewrite the doc comment to describe the abstraction (a per-connection watch consumed by whatever has cancellable work in flight) rather than naming a single caller. Also tighten the docs onsequence_staged/handle_spawnto point at the renamed map.Work towards https://github.com/MaterializeInc/database-issues/issues/6686