Skip to content

ci(scratch-aws-access): tag AssumeRole sessions with --source-identity #36639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jasonhernandez wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Draft

ci(scratch-aws-access): tag AssumeRole sessions with --source-identity #36639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ci/plugins/scratch-aws-access/hooks/pre-command
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@ set -euo pipefail

ci_unimportant_heading "Assuming scratch AWS role"

creds=$(aws sts assume-role --role-arn "$AWS_SCRATCH_ROLE_ARN" --duration-seconds 43200 --role-session-name ci)
# Tag the session with the Buildkite job ID so CloudTrail attributes the
# session to a specific build step. Falls back to a stable "unknown" so
# the call still succeeds outside Buildkite (local dev). AWS source-identity
# regex: [a-zA-Z0-9+=,.@_/-]+, max 64 chars; BUILDKITE_JOB_ID is a UUID.
source_identity="${BUILDKITE_JOB_ID:-unknown}"

creds=$(aws sts assume-role --role-arn "$AWS_SCRATCH_ROLE_ARN" --duration-seconds 43200 --role-session-name ci --source-identity "$source_identity")

AWS_ACCESS_KEY_ID=$(jq -r '.Credentials.AccessKeyId' <<< "$creds")
AWS_SECRET_ACCESS_KEY=$(jq -r '.Credentials.SecretAccessKey' <<< "$creds")
Expand Down
Loading