Skip to content

<feature>[sdk]: add dGPU attach API binding#3962

Closed
zstack-robot-1 wants to merge 1 commit into
feature-5.5.22-aiosfrom
sync/xinhao.huang/feature/dgpu-hotplug-shmem@@3
Closed

<feature>[sdk]: add dGPU attach API binding#3962
zstack-robot-1 wants to merge 1 commit into
feature-5.5.22-aiosfrom
sync/xinhao.huang/feature/dgpu-hotplug-shmem@@3

Conversation

@zstack-robot-1
Copy link
Copy Markdown
Collaborator

Summary

Regenerate SDK and testlib bindings for AttachDGpuToVm after rebasing onto feature-5.5.22-aios.

Changes

  • Add AttachDGpuToVm SDK action/result binding
  • Update testlib ApiHelper binding

Testing

  • git diff --check
  • Rebased onto upstream/feature-5.5.22-aios

Change-Id: I6467707561747461636861706962696e64

sync from gitlab !9853

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: 86165a83-4898-4a9d-9961-a262c5c458da

📥 Commits

Reviewing files that changed from the base of the PR and between 5af70e3 and 63f07c1.

⛔ Files ignored due to path filters (2)
  • sdk/src/main/java/org/zstack/sdk/AttachDGpuToVmAction.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/AttachDGpuToVmResult.java is excluded by !sdk/**
📒 Files selected for processing (1)
  • testlib/src/main/java/org/zstack/testlib/ApiHelper.groovy

工作流程概览

ApiHelper.groovy 中添加了 attachDGpuToVm 助手方法,用于创建和执行 GPU 虚拟机附着操作。该方法支持闭包配置,并在启用 API 路径追踪时自动记录操作路径。

变更说明

GPU 虚拟机附着助手方法

层级 / 文件(s) 摘要
attachDGpuToVm 助手方法
testlib/src/main/java/org/zstack/testlib/ApiHelper.groovy
新增 attachDGpuToVm 助手方法,创建 AttachDGpuToVmAction 实例,配置会话 ID,并通过闭包委托支持参数配置。当启用 apipath 系统属性时,自动设置 apiId(默认为 Platform.uuid),执行操作,并通过 ApiPathTracker 捕获和记录 API 路径到 Test.apiPaths

代码审查工作量估算

🎯 2 (简单) | ⏱️ ~8 分钟

庆祝诗

🐰 一个新方法轻轻加,
GPU 虚机现身夸,
闭包配置显灵巧,
路径追踪自成章,
助手之力托云端!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Pull request title follows the required [scope]: format and is 43 characters, well under the 72-character limit.
Description check ✅ Passed Pull request description is directly related to the changeset, providing clear summary, changes, and testing information about the AttachDGpuToVm API binding addition.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/xinhao.huang/feature/dgpu-hotplug-shmem@@3

Comment @coderabbitai help to get the list of available commands and usage tips.

@MatheMatrix MatheMatrix force-pushed the sync/xinhao.huang/feature/dgpu-hotplug-shmem@@3 branch 2 times, most recently from de6ad58 to 63f07c1 Compare May 14, 2026 09:21
SDK generation does not emit AttachDGpuToVm bindings for this branch, so
remove the manual files.

Resolves: ZSTAC-83921

Change-Id: I68697379697a7a6c636566697a687a7671656273
@MatheMatrix MatheMatrix force-pushed the sync/xinhao.huang/feature/dgpu-hotplug-shmem@@3 branch from 63f07c1 to 3d35f40 Compare May 14, 2026 10:40
@ZStack-Robot ZStack-Robot deleted the sync/xinhao.huang/feature/dgpu-hotplug-shmem@@3 branch May 18, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant