Patch Bug Involving Lifespan and Damage#158
Open
mollthecoder wants to merge 3 commits intoMaxRobinsonTheGreat:masterfrom
Open
Patch Bug Involving Lifespan and Damage#158mollthecoder wants to merge 3 commits intoMaxRobinsonTheGreat:masterfrom
mollthecoder wants to merge 3 commits intoMaxRobinsonTheGreat:masterfrom
Conversation
Setting lifespan and damage to a negative number allows for a higher time alive or more damage taken before death than expected.
MaxRobinsonTheGreat
requested changes
May 29, 2023
Owner
MaxRobinsonTheGreat
left a comment
MaxRobinsonTheGreat
left a comment
There was a problem hiding this comment.
couple questions/change request
src/Organism/Organism.js
Outdated
| this.damage++; | ||
| if (this.damage >= this.maxHealth() || Hyperparams.instaKill) { | ||
| this.die(); | ||
| if(this.die) this.die(); |
There was a problem hiding this comment.
if this.die is defined/not null? why does this need to be here?
Author
There was a problem hiding this comment.
if
this.dieis defined/not null? why does this need to be here?
My mistake, that's from something unrelated.
|
|
||
| update() { | ||
| if(this.lifetime<0) this.lifetime = 0; | ||
| if(this.damage<0) this.damage = 0; |
There was a problem hiding this comment.
For lifetime, I think I'd rather set a min value limit in the html input fields rather than check here. that way it would be obvious to user and not need to be checked every update. this is an issue tho, good catch 👍
idk about damage, why would it ever go below zero?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting lifespan and damage to a negative number allows for a higher time alive or more damage taken before death than expected.
Every update, it checks if lifetime or damage are less than 0. If so, then set them to 0.
Note: I haven't updated the
distdirectory to reflect these changes. If you merge this PR into the game, please make sure to re-build it for me.