Handle compose down with container_name case#39
Handle compose down with container_name case#39rtoohil wants to merge 1 commit intoMcrich23:mainfrom
Conversation
Mcrich23
left a comment
Mcrich23
left a comment
There was a problem hiding this comment.
This looks great! Thank you
Would it be possible to add a new dynamic test for this? You can just make a new file in Tests/Container-Compose-DynamicTests called ComposeDownTests.swift. It could probably just bring up a container and then shut it down and make sure that everything goes up and down.
This provies the missing tests for PR Mcrich23#39
This provies the missing tests for PR Mcrich23#39
I took the liberty of adding said test in #50, also with a little bit of a test hardness to quickly copy the YAML stuff in the correct folder. |
|
Thanks! I've been hit with the real life bug and haven't had time to get back to these PRs, but I appreciate the help of adding the test! |
* Handle compose down with container_name case * Providing tests for `container-compose down` This provies the missing tests for PR #39 * Correctly asserting up/down * Added copyYamlToTemporaryLocation as test helper * Addressing code review * test expect cleanup for containers running and stopping * Update ComposeDownTests.swift * Update ComposeDownTests.swift * Update ComposeDownTests.swift --------- Co-authored-by: rtoohil <ryan@ryantoohil.com> Co-authored-by: Morris Richman <81453549+Mcrich23@users.noreply.github.com>
|
Merged this with #50. |
4 participants
If you use container_name: with a custom name in your compose file, compose up properly handles that, but compose down does not, and defaults to its internal naming, will fail to stop the container, and will not throw an error, because it eats the error.
See #38
This should resolve that case. PR contributed to with Claude.